search

micro-ROS / micro_ros_zephyr_module

micro-ROS Zephyr module and sample code
Apache License 2.0
46 stars 22 forks source link

Fix Zephyr include paths #74

Closed pablogs9 closed 1 year ago

pablogs9 commented 1 year ago

Signed-off-by: Pablo Garrido pablogs9@gmail.com

pablogs9 commented 1 year ago

@mergify backport master foxy galactic

mergify[bot] commented 1 year ago

backport master foxy galactic

🟠 Waiting for conditions to match

- [ ] `merged` [:pushpin: backport requirement]
pablogs9 commented 1 year ago

Does the new include path work if CONFIG_LEGACY_INCLUDE_PATH is on?

It is ON by default. In any case, it works in both cases.

pablogs9 commented 1 year ago

Do not merge until decisions on Zephyr version support are taken

uLipe commented 1 year ago

@pablogs9 sorry for taking to long to review this.

The namespace of zephyr headers are a thing for releases of versions 3.x and above, and should not affect previous releases that adopt the namespacing on the headers.

uLipe commented 1 year ago

Just to update you, this also broke the rclc component, I will PR the fix.

uLipe commented 1 year ago

Here is it:

https://github.com/ros2/rcutils/pull/383

uLipe commented 1 year ago

@pablogs9 @Acuadros95 any updates on this?

uLipe commented 1 year ago

@pablogs9 unfortunately I don't have permission to apply here, I'll dupplicate the PR

pablogs9 commented 1 year ago

Closing in favor of https://github.com/micro-ROS/micro_ros_zephyr_module/pull/82