search

micro-ROS / rmw_microxrcedds

RMW implementation using Micro XRCE-DDS middleware.
Apache License 2.0
32 stars 25 forks source link

timesync epoch helpers #119

Closed amfern closed 3 years ago

amfern commented 3 years ago

@Acuadros95 I tried using the API you added at #117 but its not working for me as well as the eProsima, mainly because i can use 0 timeout and get the epoch time even if timeout reached,

I propose to wrap the eProsima API as follows

pablogs9 commented 3 years ago

@Acuadros95 can you take care of this?

Tests are failing.

amfern commented 3 years ago

Thanks for fixing the tests @Acuadros95

pablogs9 commented 3 years ago

@Acuadros95 LGTM, squash merge if you are ok

Acuadros95 commented 3 years ago

@amfern I have included a check for session synchronized on the rmw_uros_epoch functions.

I think it looks great, thanks for your suggestions.

amfern commented 3 years ago

yes, this works perfectly with my code, thanks!