search

micro-ROS / rmw_microxrcedds

RMW implementation using Micro XRCE-DDS middleware.
Apache License 2.0
32 stars 25 forks source link

Add Binary entity creation mode #123

Closed pablogs9 closed 3 years ago

pablogs9 commented 3 years ago

Test not passing due to agent does not have binary functionality. Try again when https://github.com/eProsima/Micro-XRCE-DDS-Agent/pull/239 merged

pablogs9 commented 3 years ago

Marie Kondo

github-actions[bot] commented 3 years ago

Static memory analysis

Default configuration

MTU: 512 B Input buffer size: 2048 B Input history: 4 Output buffer size: 2048 B Output history: 4

Entity Qty Size per unit
Context 1 5584 B
Topic 12 56 B
Service 4 80 B
Client 4 72 B
Subscription 4 168 B
Publisher 8 184 B
Node 4 56 B
Static input buffer 8 2120 B

TOTAL: 25020 B

codecov-commenter commented 3 years ago

Codecov Report

Merging #123 (aa10c64) into foxy (8e41732) will decrease coverage by 2.54%. The diff coverage is 69.01%.

Impacted file tree graph

@@            Coverage Diff             @@
##             foxy     #123      +/-   ##
==========================================
- Coverage   50.39%   47.85%   -2.55%     
==========================================
  Files          35       35              
  Lines        1502     1490      -12     
  Branches      307      307              
==========================================
- Hits          757      713      -44     
- Misses        519      567      +48     
+ Partials      226      210      -16
Impacted Files Coverage Δ
rmw_microxrcedds_c/src/rmw_get_gid_for_publisher.c 0.00% <0.00%> (ø)
rmw_microxrcedds_c/src/rmw_uros_options.c 39.80% <33.33%> (-0.98%) :arrow_down:
rmw_microxrcedds_c/src/rmw_publisher.c 47.69% <58.33%> (-1.57%) :arrow_down:
rmw_microxrcedds_c/src/rmw_subscription.c 51.51% <66.66%> (-0.66%) :arrow_down:
rmw_microxrcedds_c/src/rmw_microxrcedds_topic.c 53.06% <83.33%> (+4.91%) :arrow_up:
rmw_microxrcedds_c/src/utils.c 25.00% <88.23%> (-23.10%) :arrow_down:
rmw_microxrcedds_c/src/rmw_client.c 53.46% <100.00%> (-0.24%) :arrow_down:
rmw_microxrcedds_c/src/rmw_node.c 63.00% <100.00%> (+0.86%) :arrow_up:
rmw_microxrcedds_c/src/rmw_service.c 52.94% <100.00%> (-0.27%) :arrow_down:
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c9733a6...aa10c64. Read the comment docs.

github-actions[bot] commented 3 years ago

Static memory analysis

Default configuration

MTU: 512 B Input buffer size: 2048 B Input history: 4 Output buffer size: 2048 B Output history: 4

Entity Qty Size per unit
Context 1 5584 B
Topic 12 56 B
Service 4 80 B
Client 4 72 B
Subscription 4 168 B
Publisher 8 184 B
Node 4 56 B
Static input buffer 8 2120 B

TOTAL: 25020 B

pablogs9 commented 3 years ago

Merging on Tuesday 4th May

github-actions[bot] commented 3 years ago

Static memory analysis

Default configuration

MTU: 512 B Input buffer size: 2048 B Input history: 4 Output buffer size: 2048 B Output history: 4

Entity Qty Size per unit
Context 1 5584 B
Topic 12 56 B
Service 4 80 B
Client 4 72 B
Subscription 4 168 B
Publisher 8 184 B
Node 4 56 B
Static input buffer 8 2120 B

TOTAL: 25020 B