Static memory analysis

Default configuration

MTU: 512 B Input buffer size: 2048 B Input history: 4 Output buffer size: 2048 B Output history: 4

Entity	Qty	Size per unit
Context	1	5584 B
Topic	12	56 B
Service	4	80 B
Client	4	72 B
Subscription	4	168 B
Publisher	8	184 B
Node	4	56 B
Static input buffer	8	2120 B

TOTAL: 25020 B

codecov-commenter commented 3 years ago

Codecov Report

Merging #142 (c20adb8) into main (beca133) will decrease coverage by 0.26%. The diff coverage is 53.33%.

@@            Coverage Diff             @@
##             main     #142      +/-   ##
==========================================
- Coverage   48.17%   47.90%   -0.27%     
==========================================
  Files          41       41              
  Lines        1507     1507              
  Branches      302      303       +1     
==========================================
- Hits          726      722       -4     
- Misses        576      578       +2     
- Partials      205      207       +2

Impacted Files	Coverage Δ
rmw_microxrcedds_c/src/rmw_node.c	`63.00% <0.00%> (ø)`
rmw_microxrcedds_c/src/rmw_publisher.c	`49.25% <0.00%> (ø)`
rmw_microxrcedds_c/src/rmw_service.c	`54.00% <0.00%> (ø)`
rmw_microxrcedds_c/src/rmw_subscription.c	`53.33% <0.00%> (+0.39%)`	:arrow_up:
rmw_microxrcedds_c/src/rmw_client.c	`54.08% <50.00%> (-0.47%)`	:arrow_down:
rmw_microxrcedds_c/src/rmw_microxrcedds_topic.c	`50.00% <75.00%> (-3.07%)`	:arrow_down:
rmw_microxrcedds_c/src/types.c	`58.94% <100.00%> (+0.43%)`	:arrow_up:
rmw_microxrcedds_c/src/utils.c	`18.57% <0.00%> (-2.15%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update beca133...c20adb8. Read the comment docs.

bjv-capra commented 3 years ago

I have checked this PR, it does what it intends to. There's a problem with the RCL though, as it does

rmw_ret_t ret =
      rmw_destroy_subscription(rmw_node, subscription->impl->rmw_handle);
    if (ret != RMW_RET_OK) {
      RCL_SET_ERROR_MSG(rmw_get_error_string().str);
      result = RCL_RET_ERROR;
    }

pablogs9 commented 3 years ago

@mergify backport foxy galactic

mergify[bot] commented 3 years ago

Command backport foxy galactic: success

Backports have been created

#144 Update destroy behavior to use RMW_RET_TIMEOUT (backport #142) has been created for branch foxy

#145 Update destroy behavior to use RMW_RET_TIMEOUT (backport #142) has been created for branch galactic

Hey, I reacted but my real name is @Mergifyio

micro-ROS / rmw_microxrcedds

Update destroy behavior to use RMW_RET_TIMEOUT #142

Static memory analysis

Codecov Report