micro-ROS / rmw_microxrcedds

RMW implementation using Micro XRCE-DDS middleware.
Apache License 2.0
32 stars 25 forks source link

Update destroy behavior to use RMW_RET_TIMEOUT (backport #142) #144

Closed mergify[bot] closed 3 years ago

mergify[bot] commented 3 years ago

This is an automatic backport of pull request #142 done by Mergify.


Mergify commands and options
More conditions and actions can be found in the [documentation](https://docs.mergify.io/). You can also trigger Mergify actions by commenting on this pull request: - `@Mergifyio refresh` will re-evaluate the rules - `@Mergifyio rebase` will rebase this PR on its base branch - `@Mergifyio update` will merge the base branch into this PR - `@Mergifyio backport ` will backport this PR on `` branch Additionally, on Mergify [dashboard](https://dashboard.mergify.io/) you can: - look at your merge queues - generate the Mergify configuration with the config editor. Finally, you can contact us on https://mergify.io/
github-actions[bot] commented 3 years ago

Static memory analysis

Default configuration

MTU: 512 B Input buffer size: 2048 B Input history: 4 Output buffer size: 2048 B Output history: 4

Entity Qty Size per unit
Context 1 5584 B
Topic 12 56 B
Service 4 80 B
Client 4 72 B
Subscription 4 168 B
Publisher 8 184 B
Node 4 56 B
Static input buffer 8 2120 B

TOTAL: 25020 B

codecov-commenter commented 3 years ago

Codecov Report

Merging #144 (bfd72ed) into foxy (a546bbd) will decrease coverage by 0.26%. The diff coverage is 53.33%.

:exclamation: Current head bfd72ed differs from pull request most recent head 0f67b5f. Consider uploading reports for the commit 0f67b5f to get more accurate results Impacted file tree graph

@@            Coverage Diff             @@
##             foxy     #144      +/-   ##
==========================================
- Coverage   48.16%   47.89%   -0.27%     
==========================================
  Files          39       39              
  Lines        1495     1495              
  Branches      302      303       +1     
==========================================
- Hits          720      716       -4     
- Misses        570      572       +2     
- Partials      205      207       +2     
Impacted Files Coverage Δ
rmw_microxrcedds_c/src/rmw_node.c 63.00% <0.00%> (ø)
rmw_microxrcedds_c/src/rmw_publisher.c 49.25% <0.00%> (ø)
rmw_microxrcedds_c/src/rmw_service.c 54.00% <0.00%> (ø)
rmw_microxrcedds_c/src/rmw_subscription.c 53.33% <0.00%> (+0.39%) :arrow_up:
rmw_microxrcedds_c/src/rmw_client.c 54.08% <50.00%> (-0.47%) :arrow_down:
rmw_microxrcedds_c/src/rmw_microxrcedds_topic.c 50.00% <75.00%> (-3.07%) :arrow_down:
rmw_microxrcedds_c/src/types.c 58.94% <100.00%> (+0.43%) :arrow_up:
rmw_microxrcedds_c/src/utils.c 18.57% <0.00%> (-2.15%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a546bbd...0f67b5f. Read the comment docs.