search

micro-ROS / rmw_microxrcedds

RMW implementation using Micro XRCE-DDS middleware.
Apache License 2.0
32 stars 25 forks source link

Force compiler to search for header locally #180

Closed roncapat closed 2 years ago

roncapat commented 2 years ago
header may clash with some cmake toolchains, because it is a very common header name. Here we force the compiler to search in the neighbourhood of memory.c file. This solves a problem detected in the process of https://github.com/micro-ROS/micro_ros_setup/issues/397
pablogs9 commented 2 years ago

@mergify backport main foxy

mergify[bot] commented 2 years ago

Command backport main foxy: pending

backport main foxy is pending

Hey, I reacted but my real name is @Mergifyio

pablogs9 commented 2 years ago

Check CI please

roncapat commented 2 years ago

Guys, could you tell me what action from me is needed, if any, after the 4 commits that I saw after mine? :)

pablogs9 commented 2 years ago

IMO we should change the name of memory.h and keep the include as it is, because is the format that ROS cpplint requires.

roncapat commented 2 years ago

@pablogs9 I agree with you. Who is in charge of the decision for the new name? Also, consider that this folder has include files alongside source files, while it would be better to move the headers in a subfolder or another include/ position around in the tree and #include files by "namespace". I mean, something to get to a #include "micro_ros/memory.h or similar.

pablogs9 commented 2 years ago

#include "micro_ros_internal/memory.h should be ok. I'll do it when I have a free timeslot.

pablogs9 commented 2 years ago

Superseed by https://github.com/micro-ROS/rmw_microxrcedds/pull/181

pablogs9 commented 2 years ago

Merged https://github.com/micro-ROS/rmw_microxrcedds/pull/181