Closed roncapat closed 2 years ago
@mergify backport main foxy
Command backport main foxy
: pending
backport main foxy is pending
Hey, I reacted but my real name is @Mergifyio
Check CI please
Guys, could you tell me what action from me is needed, if any, after the 4 commits that I saw after mine? :)
IMO we should change the name of memory.h and keep the include as it is, because is the format that ROS cpplint requires.
@pablogs9 I agree with you. Who is in charge of the decision for the new name?
Also, consider that this folder has include files alongside source files, while it would be better to move the headers in a subfolder or another include/ position around in the tree and #include files by "namespace". I mean, something to get to a #include "micro_ros/memory.h
or similar.
#include "micro_ros_internal/memory.h
should be ok. I'll do it when I have a free timeslot.