micro-ROS / rmw_microxrcedds

RMW implementation using Micro XRCE-DDS middleware.
Apache License 2.0
32 stars 25 forks source link

Fix guard conditions #209

Closed pablogs9 closed 2 years ago

pablogs9 commented 2 years ago

Signed-off-by: Pablo Garrido pablogs9@gmail.com

github-actions[bot] commented 2 years ago

Static memory analysis

Default configuration

MTU: 512 B Input buffer size: 2048 B Input history: 4 Output buffer size: 2048 B Output history: 4

Entity Qty Size per unit
Context 2 5616 B
Topic 8 56 B
Service 4 248 B
Client 4 248 B
Subscription 4 272 B
Publisher 4 288 B
Node 4 208 B
Static input buffer 8 2136 B
Init options 6 64 B
Wait sets 4 56 B
Guard Condition 4 64 B

TOTAL: 34468 B

codecov-commenter commented 2 years ago

Codecov Report

Merging #209 (4640e81) into main (e58676c) will increase coverage by 1.39%. The diff coverage is 94.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #209      +/-   ##
==========================================
+ Coverage   47.80%   49.19%   +1.39%     
==========================================
  Files          42       42              
  Lines        1686     1687       +1     
  Branches      332      332              
==========================================
+ Hits          806      830      +24     
+ Misses        670      644      -26     
- Partials      210      213       +3     
Impacted Files Coverage Δ
rmw_microxrcedds_c/src/rmw_wait.c 85.71% <92.85%> (+12.69%) :arrow_up:
rmw_microxrcedds_c/src/rmw_guard_condition.c 63.15% <100.00%> (+63.15%) :arrow_up:
...w_microxrcedds_c/src/rmw_trigger_guard_condition.c 40.00% <100.00%> (+40.00%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e58676c...4640e81. Read the comment docs.

pablogs9 commented 2 years ago

@mergify backport foxy galactic

github-actions[bot] commented 2 years ago

Static memory analysis

Default configuration

MTU: 512 B Input buffer size: 2048 B Input history: 4 Output buffer size: 2048 B Output history: 4

Entity Qty Size per unit
Context 2 5616 B
Topic 8 56 B
Service 4 248 B
Client 4 248 B
Subscription 4 272 B
Publisher 4 288 B
Node 4 208 B
Static input buffer 8 2136 B
Init options 6 64 B
Wait sets 4 56 B
Guard Condition 4 64 B

TOTAL: 34468 B

mergify[bot] commented 2 years ago

backport foxy galactic

🟠 Waiting for conditions to match

- [ ] `merged` [:pushpin: backport requirement]

Hey, I reacted but my real name is @Mergifyio

mergify[bot] commented 2 years ago

backport foxy galactic

✅ Backports have been created

* [#210 Fix guard conditions (backport #209)](https://github.com/micro-ROS/rmw_microxrcedds/pull/210) has been created for branch `foxy` * [#211 Fix guard conditions (backport #209)](https://github.com/micro-ROS/rmw_microxrcedds/pull/211) has been created for branch `galactic`