micro-ROS / rmw_microxrcedds

RMW implementation using Micro XRCE-DDS middleware.
Apache License 2.0
30 stars 23 forks source link

Add cancel data to destroy subscription #224

Closed Acuadros95 closed 2 years ago

pablogs9 commented 2 years ago

Could you add the same for requesters y repliers?

github-actions[bot] commented 2 years ago

Static memory analysis

Default configuration

MTU: 512 B Input buffer size: 2048 B Input history: 4 Output buffer size: 2048 B Output history: 4

Entity Qty Size per unit
Context 2 5616 B
Topic 8 56 B
Service 4 248 B
Client 4 248 B
Subscription 4 272 B
Publisher 4 288 B
Node 4 208 B
Static input buffer 8 2136 B
Init options 6 64 B
Wait sets 4 56 B
Guard Condition 4 64 B

TOTAL: 34468 B

github-actions[bot] commented 2 years ago

Static memory analysis

Default configuration

MTU: 512 B Input buffer size: 2048 B Input history: 4 Output buffer size: 2048 B Output history: 4

Entity Qty Size per unit
Context 2 5616 B
Topic 8 56 B
Service 4 248 B
Client 4 248 B
Subscription 4 272 B
Publisher 4 288 B
Node 4 208 B
Static input buffer 8 2136 B
Init options 6 64 B
Wait sets 4 56 B
Guard Condition 4 64 B

TOTAL: 34468 B

codecov-commenter commented 2 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (galactic@801c8fc). Click here to learn what that means. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             galactic     #224   +/-   ##
===========================================
  Coverage            ?   50.05%           
===========================================
  Files               ?       43           
  Lines               ?     1678           
  Branches            ?      478           
===========================================
  Hits                ?      840           
  Misses              ?      615           
  Partials            ?      223           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 801c8fc...4e5517c. Read the comment docs.

Acuadros95 commented 2 years ago

@mergify backport foxy main

mergify[bot] commented 2 years ago

backport foxy main

✅ Backports have been created

* [#225 Add cancel data to destroy subscription (backport #224)](https://github.com/micro-ROS/rmw_microxrcedds/pull/225) has been created for branch `foxy` * [#226 Add cancel data to destroy subscription (backport #224)](https://github.com/micro-ROS/rmw_microxrcedds/pull/226) has been created for branch `main`

Hey, I reacted but my real name is @Mergifyio