micro-ROS / rmw_microxrcedds

RMW implementation using Micro XRCE-DDS middleware.
Apache License 2.0
30 stars 23 forks source link

Add cancel data to destroy subscription (backport #224) #226

Closed mergify[bot] closed 2 years ago

mergify[bot] commented 2 years ago

This is an automatic backport of pull request #224 done by Mergify.


Mergify commands and options
More conditions and actions can be found in the [documentation](https://docs.mergify.com/). You can also trigger Mergify actions by commenting on this pull request: - `@Mergifyio refresh` will re-evaluate the rules - `@Mergifyio rebase` will rebase this PR on its base branch - `@Mergifyio update` will merge the base branch into this PR - `@Mergifyio backport ` will backport this PR on `` branch Additionally, on Mergify [dashboard](https://dashboard.mergify.com/) you can: - look at your merge queues - generate the Mergify configuration with the config editor. Finally, you can contact us on https://mergify.com
github-actions[bot] commented 2 years ago

Static memory analysis

Default configuration

MTU: 512 B Input buffer size: 2048 B Input history: 4 Output buffer size: 2048 B Output history: 4

Entity Qty Size per unit
Context 2 5616 B
Topic 8 56 B
Service 4 248 B
Client 4 248 B
Subscription 4 272 B
Publisher 4 288 B
Node 4 208 B
Static input buffer 8 2136 B
Init options 6 64 B
Wait sets 4 56 B
Guard Condition 4 64 B

TOTAL: 34468 B

codecov-commenter commented 2 years ago

Codecov Report

Merging #226 (73e2ab0) into main (950a16f) will increase coverage by 0.66%. The diff coverage is 100.00%.

:exclamation: Current head 73e2ab0 differs from pull request most recent head 00dd7e4. Consider uploading reports for the commit 00dd7e4 to get more accurate results Impacted file tree graph

@@            Coverage Diff             @@
##             main     #226      +/-   ##
==========================================
+ Coverage   49.33%   50.00%   +0.66%     
==========================================
  Files          43       43              
  Lines        1662     1680      +18     
  Branches      478      478              
==========================================
+ Hits          820      840      +20     
+ Misses        619      617       -2     
  Partials      223      223              
Impacted Files Coverage Δ
rmw_microxrcedds_c/src/rmw_client.c 52.33% <100.00%> (+2.83%) :arrow_up:
rmw_microxrcedds_c/src/rmw_service.c 51.85% <100.00%> (+2.83%) :arrow_up:
rmw_microxrcedds_c/src/rmw_subscription.c 53.28% <100.00%> (+2.13%) :arrow_up:
rmw_microxrcedds_c/src/utils.c 29.09% <0.00%> (+1.21%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 950a16f...00dd7e4. Read the comment docs.