search

micro-ROS / rmw_microxrcedds

RMW implementation using Micro XRCE-DDS middleware.
Apache License 2.0
30 stars 23 forks source link

Fix topic and type name handling (backport #254) #256

Closed mergify[bot] closed 2 years ago

mergify[bot] commented 2 years ago

This is an automatic backport of pull request #254 done by Mergify.

Mergify commands and options
More conditions and actions can be found in the [documentation](https://docs.mergify.com/). You can also trigger Mergify actions by commenting on this pull request: - `@Mergifyio refresh` will re-evaluate the rules - `@Mergifyio rebase` will rebase this PR on its base branch - `@Mergifyio update` will merge the base branch into this PR - `@Mergifyio backport ` will backport this PR on `` branch Additionally, on Mergify [dashboard](https://dashboard.mergify.com/) you can: - look at your merge queues - generate the Mergify configuration with the config editor. Finally, you can contact us on https://mergify.com
github-actions[bot] commented 2 years ago

Static memory analysis

Default configuration

MTU: 512 B Input buffer size: 2048 B Input history: 4 Output buffer size: 2048 B Output history: 4

Entity Qty Size per unit
Context 2 5616 B
Topic 8 56 B
Service 4 248 B
Client 4 248 B
Subscription 4 272 B
Publisher 4 280 B
Node 4 208 B
Static input buffer 8 2136 B
Init options 6 64 B
Wait sets 4 56 B
Guard Condition 4 64 B

TOTAL: 34436 B

codecov-commenter commented 2 years ago

Codecov Report

Merging #256 (f05a905) into foxy (2fec703) will decrease coverage by 1.09%. The diff coverage is 25.58%.

:exclamation: Current head f05a905 differs from pull request most recent head b202d74. Consider uploading reports for the commit b202d74 to get more accurate results

@@            Coverage Diff             @@
##             foxy     #256      +/-   ##
==========================================
- Coverage   50.11%   49.02%   -1.10%     
==========================================
  Files          41       41              
  Lines        1678     1695      +17     
  Branches      478      492      +14     
==========================================
- Hits          841      831      -10     
- Misses        613      632      +19     
- Partials      224      232       +8
Impacted Files Coverage Δ
rmw_microxrcedds_c/src/rmw_client.c 47.78% <0.00%> (-4.55%) :arrow_down:
rmw_microxrcedds_c/src/rmw_microxrcedds_topic.c 43.54% <0.00%> (-10.16%) :arrow_down:
rmw_microxrcedds_c/src/rmw_service.c 47.36% <0.00%> (-4.49%) :arrow_down:
rmw_microxrcedds_c/src/utils.c 27.16% <64.70%> (-1.94%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2fec703...b202d74. Read the comment docs.