micro-ROS / rmw_microxrcedds

RMW implementation using Micro XRCE-DDS middleware.
Apache License 2.0
35 stars 27 forks source link

Fix memory release on entities creation (backport #280) #281

Closed mergify[bot] closed 1 year ago

mergify[bot] commented 1 year ago

This is an automatic backport of pull request #280 done by Mergify.


Mergify commands and options
More conditions and actions can be found in the [documentation](https://docs.mergify.com/). You can also trigger Mergify actions by commenting on this pull request: - `@Mergifyio refresh` will re-evaluate the rules - `@Mergifyio rebase` will rebase this PR on its base branch - `@Mergifyio update` will merge the base branch into this PR - `@Mergifyio backport ` will backport this PR on `` branch Additionally, on Mergify [dashboard](https://dashboard.mergify.com/) you can: - look at your merge queues - generate the Mergify configuration with the config editor. Finally, you can contact us on https://mergify.com
github-actions[bot] commented 1 year ago

Static memory analysis

Default configuration

MTU: 512 B Input buffer size: 2048 B Input history: 4 Output buffer size: 2048 B Output history: 4

Entity Qty Size per unit
Context 2 5616 B
Topic 8 56 B
Service 4 248 B
Client 4 248 B
Subscription 4 280 B
Publisher 4 288 B
Node 4 208 B
Static input buffer 8 2136 B
Init options 6 64 B
Wait sets 4 56 B
Guard Condition 4 64 B

TOTAL: 34500 B

codecov-commenter commented 1 year ago

Codecov Report

Base: 47.90% // Head: 47.82% // Decreases project coverage by -0.09% :warning:

Coverage data is based on head (1a87a98) compared to base (a08c301). Patch coverage: 42.30% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #281 +/- ## ========================================== - Coverage 47.90% 47.82% -0.09% ========================================== Files 45 45 Lines 1745 1744 -1 Branches 501 508 +7 ========================================== - Hits 836 834 -2 - Misses 678 679 +1 Partials 231 231 ``` | [Impacted Files](https://codecov.io/gh/micro-ROS/rmw_microxrcedds/pull/281?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=micro-ROS) | Coverage Δ | | |---|---|---| | [rmw\_microxrcedds\_c/src/rmw\_node.c](https://codecov.io/gh/micro-ROS/rmw_microxrcedds/pull/281?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=micro-ROS#diff-cm13X21pY3JveHJjZWRkc19jL3NyYy9ybXdfbm9kZS5j) | `39.25% <0.00%> (-3.18%)` | :arrow_down: | | [rmw\_microxrcedds\_c/src/rmw\_microxrcedds\_topic.c](https://codecov.io/gh/micro-ROS/rmw_microxrcedds/pull/281?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=micro-ROS#diff-cm13X21pY3JveHJjZWRkc19jL3NyYy9ybXdfbWljcm94cmNlZGRzX3RvcGljLmM=) | `43.33% <25.00%> (-0.22%)` | :arrow_down: | | [rmw\_microxrcedds\_c/src/rmw\_publisher.c](https://codecov.io/gh/micro-ROS/rmw_microxrcedds/pull/281?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=micro-ROS#diff-cm13X21pY3JveHJjZWRkc19jL3NyYy9ybXdfcHVibGlzaGVyLmM=) | `48.09% <60.00%> (ø)` | | | [rmw\_microxrcedds\_c/src/rmw\_subscription.c](https://codecov.io/gh/micro-ROS/rmw_microxrcedds/pull/281?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=micro-ROS#diff-cm13X21pY3JveHJjZWRkc19jL3NyYy9ybXdfc3Vic2NyaXB0aW9uLmM=) | `52.51% <60.00%> (ø)` | | | [rmw\_microxrcedds\_c/src/rmw\_client.c](https://codecov.io/gh/micro-ROS/rmw_microxrcedds/pull/281?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=micro-ROS#diff-cm13X21pY3JveHJjZWRkc19jL3NyYy9ybXdfY2xpZW50LmM=) | `46.55% <100.00%> (+1.17%)` | :arrow_up: | | [rmw\_microxrcedds\_c/src/rmw\_service.c](https://codecov.io/gh/micro-ROS/rmw_microxrcedds/pull/281?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=micro-ROS#diff-cm13X21pY3JveHJjZWRkc19jL3NyYy9ybXdfc2VydmljZS5j) | `45.68% <100.00%> (+0.68%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=micro-ROS). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=micro-ROS)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.