RMW client key generation

micro-ROS / rmw_microxrcedds

RMW implementation using Micro XRCE-DDS middleware.

Apache License 2.0

35 stars 26 forks source link

RMW client key generation #51

Closed pablogs9 closed 4 years ago

pablogs9 commented 4 years ago

This PR adds random seed to XRCE client key generation

iluetkeb commented 4 years ago

I'm okay with this approach to generate a client key.

That said, currently the client key is used as some sort of authentication as well. If I snoop XRCE-DDS traffic and then use the same client key, I will probably get the same data as the original client. This does not appear secure.

Therefore, for cases where communication goes over public networks, I would strongly suggest having an additional security mechanism.

julionce commented 4 years ago

Hi @iluetkeb, it is something that eProsima has to add to the Micro XRCE-DDS roadmap. The DDS-XRCE standard leaves the security as implementation-defined and it just suggests that TLS/DTLS could be used to provide such security.