Fix destroying safety - Githubissues

micro-ROS / rmw_microxrcedds

RMW implementation using Micro XRCE-DDS middleware.

Apache License 2.0

35 stars 26 forks source link

Closed pablogs9 closed 4 years ago

pablogs9 commented 4 years ago

This PR fix situation when an already destroyed node is destroyed.

First commit should fail.

pablogs9 commented 4 years ago

@jamoralp how would you name check_uxrce_rmw_identifier function?

jamoralp commented 4 years ago

@jamoralp how would you name check_uxrce_rmw_identifier function?

Hmm, maybe is_uxrce_rmw_id_valid/is_uxrce_rmw_identifier_valid?