norro commented 3 years ago

Before executing a requested mode change, i.e. applying the according changes, it is now checking whether the mode is already active. If so, no action is taken, but mode change service request is still returned with success.

https://github.com/micro-ROS/system_modes/issues/60

codecov[bot] commented 3 years ago

Codecov Report

Merging #67 (eca34d5) into master (02b4b3e) will decrease coverage by 0.03%. The diff coverage is 40.00%.

@@            Coverage Diff             @@
##           master      #67      +/-   ##
==========================================
- Coverage   27.67%   27.63%   -0.04%     
==========================================
  Files          12       12              
  Lines         990      995       +5     
  Branches      710      714       +4     
==========================================
+ Hits          274      275       +1     
+ Misses        259      258       -1     
- Partials      457      462       +5

Impacted Files	Coverage Δ
system_modes/src/system_modes/mode_manager.cpp	`16.54% <40.00%> (+0.83%)`	:arrow_up:
system_modes/src/system_modes/mode_inference.cpp	`34.87% <0.00%> (-0.55%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 02b4b3e...eca34d5. Read the comment docs.

norro commented 3 years ago

Thanks for the review, Niels!

micro-ROS / system_modes

Mode manager prevents redundant mode changes #67

Codecov Report