Add CORS headers to microservice

micro-analytics / micro-analytics-cli

Public analytics as a Node.js microservice. No sysadmin experience required! 📈

MIT License

734 stars 39 forks source link

Add CORS headers to microservice #17

Closed juandjara closed 7 years ago

codecov-io commented 7 years ago

Current coverage is 93.24% (diff: 100%)

Merging #17 into master will increase coverage by 0.09%

@@             master        #17   diff @@
==========================================
  Files             4          4          
  Lines            73         74     +1   
  Methods          13         13          
  Messages          0          0          
  Branches         14         14          
==========================================
+ Hits             68         69     +1   
  Misses            5          5          
  Partials          0          0

Powered by Codecov. Last update 6aebd25...9c7e326

relekang commented 7 years ago

Maybe this could be configurable? Would be nice to set a list of the domains it is used from.

mxstbr commented 7 years ago

Why would somebody restrict the domains this can be used from, what's the use case?

Thanks for the PR @juandjara, this is a great addition!

relekang commented 7 years ago

Filtering out local calls from development of a website using this, but this might not be the best way to do it 😛

mxstbr commented 7 years ago

See #11, I think this should be fine?

mxstbr commented 7 years ago

LGTM, thanks so much!