search

micro-analytics / micro-analytics-cli

Public analytics as a Node.js microservice. No sysadmin experience required! 📈
MIT License
734 stars 39 forks source link

Filter is not passed to db.get #33

Closed sean-roberts closed 7 years ago

sean-roberts commented 7 years ago

We are not passing filter options to db.get()

sean-roberts commented 7 years ago

I'll fix after the wildcard stuff is merged...

mxstbr commented 7 years ago

Need to add tests for that too, to make sure we don't regress and all adapter implement that behavior.

sean-roberts commented 7 years ago

we also don't support passing options under the field of 'filter'

7rulnik commented 7 years ago

@relekang I can take this issue. Should we increment currentViews and push view if since or before query passed?

relekang commented 7 years ago

Great 🙂

Should we increment currentViews and push view if since or before query passed?

Not sure, but as a start we should just pass the filters to get all the places.