Closed abdulhannanali closed 7 years ago
@@ master #39 diff @@
==========================================
Files 3 3
Lines 55 55
Methods 4 4
Messages 0 0
Branches 12 12
==========================================
Hits 45 45
Misses 10 10
Partials 0 0
Powered by Codecov. Last update 09442c1...e6b06c3
I also would like to know if this locks functionality will work when we are using multiple processes. What are the alternatives in case we have multiple processes of one micro function running. Can we instead implement an increment functionality in the DB. Db such as redis provides us with this increment
function which is atomic.
We've thought about moving the atomicity out to the database adapters, see #14 and related issues. Not sure yet if we'll go down that route, /cc @sean-roberts
I don't think changing this is necessary. This is for sure standard in node. Maybe not in browsers according to mdn, but it's been in node quite a long time. :man_shrugging: As far as the locking convo, let's move that to a discussion ticket
Want to give your thoughts on https://github.com/micro-analytics/micro-analytics/issues/40 ?
Closing this since we'll probably move forward with #40!
Thanks for taking the time to submit a PR and kicking off this discussion @abdulhannanali!
setImmediate
is a non standard feature and the behavior is non stable. In thesrc/utils.js
I have replaced thesetImmediate
function call with an this alternative