search

micro-analytics / micro-analytics-cli

Public analytics as a Node.js microservice. No sysadmin experience required! 📈
MIT License
734 stars 39 forks source link

Move update-notifier -> dependency #42

Closed jimthedev closed 7 years ago

jimthedev commented 7 years ago

update-notifier is used as a dependency but is listed as a dev dependency. This moves it to be a dependency.

codecov-io commented 7 years ago

Codecov Report

Merging #42 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #42   +/-   ##
=======================================
  Coverage   81.81%   81.81%           
=======================================
  Files           3        3           
  Lines          55       55           
  Branches       12       12           
=======================================
  Hits           45       45           
  Misses         10       10

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 09442c1...c567734. Read the comment docs.

jimthedev commented 7 years ago

Hi @mxstbr, any chance this can get merged and released as a 1.2.0-9? Right now npm installing -8 errors asking for update-notifier.

jimthedev commented 7 years ago

High five

mxstbr commented 7 years ago

Releasing as 1.2.0-9, also added you to the org. Please help us finish the adapter stuff I really want to get it done!

jimthedev commented 7 years ago

I saw that. Will do.