search

micro-analytics / micro-analytics-cli

Public analytics as a Node.js microservice. No sysadmin experience required! 📈
MIT License
734 stars 39 forks source link

Add ability to change db path from CLI #5

Closed mxstbr closed 7 years ago

mxstbr commented 7 years ago

cc @developit, does this fit your needs?

codecov-io commented 7 years ago

Current coverage is 93.15% (diff: 100%)

Merging #5 into master will not change coverage

@@             master         #5   diff @@
==========================================
  Files             4          4          
  Lines            73         73          
  Methods          13         13          
  Messages          0          0          
  Branches         12         13     +1   
==========================================
  Hits             68         68          
  Misses            5          5          
  Partials          0          0

Powered by Codecov. Last update e899065...4703a1d

developit commented 7 years ago

Might actually be easier to use an env var (just a thought). Either is good though. Env vars just make it a little simpler in docker. I know I sound like I'm selling docker, it's just I'm looking to deploy this to dokku and it uses env vars for config. I can always set up the app to do --db-path $DB_PATH if need be.

mxstbr commented 7 years ago

Oh yeah that actually makes the implementation way easier too, good call!

mxstbr commented 7 years ago

Switched to using process.env.DB_PATH. Whatcha think?

developit commented 7 years ago

Works for me! 👍