Closed relekang closed 7 years ago
Merging #67 into master will increase coverage by
3.87%
. The diff coverage is100%
.
@@ Coverage Diff @@
## master #67 +/- ##
==========================================
+ Coverage 72.03% 75.91% +3.87%
==========================================
Files 6 7 +1
Lines 118 137 +19
Branches 25 31 +6
==========================================
+ Hits 85 104 +19
Misses 31 31
Partials 2 2
Impacted Files | Coverage Δ | |
---|---|---|
src/adapter-utils.js | 100% <100%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 334fe5a...07c5029. Read the comment docs.
I first thought that it should just be in the main package, but might be nice to have a separate package.
I think a monorepo is starting to make sense. Not just for this repo, but also for flat-file-db and memory adapters. We have a few changes that lately need to be synced across repositories.
What do you think about merging this as is and then I can create a pr for setting up lerna?
Sure, sounds great to me!
These utils are nice to have for all the adapters that need to do filtering in javascript.
Fixes #63
Link to rendered version of writing-adapters.md