search

micro-fan / aiozk

Asyncio client for zookeeper
MIT License
49 stars 20 forks source link

barrier: Fix double barrier test code #58

Closed rhdxmr closed 4 years ago

rhdxmr commented 4 years ago

This is a pull request for PR#56 I made a new branch for this PR at this repository directly.

asyncio.gather returns immediately when one of awaitables raises an exception. So it is possible that the first task raises an exception at the .enter() method before the last task deletes its znode. If it happens, the assertion of that no children znodes fails.

rhdxmr commented 4 years ago

@cybergrind And also I add 2 more misc commits.

cybergrind commented 4 years ago

@rhdxmr yep, it is fine to put them into one branch. what we're going to do about #57 ?

rhdxmr commented 4 years ago

@cybergrind I rebased #57 onto master branch and pushed it again. Please, check that PR :)