NIDAQ: Added analog input functionality

micro-manager / mmCoreAndDevices

Micro-Manager's device control layer, written in C++

43 stars 112 forks source link

NIDAQ: Added analog input functionality #514

Open SAJHCamps opened 1 month ago

SAJHCamps commented 1 month ago

Expanded the driver to be able to read analog inputs and capture traces. Has been tested with NI MAX emulation software but not with actual hardware.

Things to check before merging:

[x] Run tests with actual hardware.
[x] Currently the trace values are read out one sample at the time but I am unsure whether this is a mistake on my side or a side effect of the emulator.
[x] Check whether the NIDAQmx commands used are available in the 9.2 version of the library.

nicost commented 2 weeks ago

Your branch compiles fine with the 9.2 version of NIDAQms that we are building against. There are a couple of compiler warnings, but those will be easy to fix before merging. Let me know if it is ready for merging.

SAJHCamps commented 1 week ago

I just went through the compiler warnings and the ones that are left fall into two categories:

type conversions, because functions relating to device properties want doubles and NIDAQxm wants float64. Similarly NIDAQxm wants UInt64 but size() for vectors returns t_size.
unreferenced formal parameters, CSignalIOBase requires several functions which an input port cannot satisfy like StartDASequence(), so DEVICE_UNSUPPORTED_COMMAND is returned without using the parameter.

The NI DAQ card arrived last week, so I expect the other two tasks to be checked off somewhere this week

SAJHCamps commented 1 week ago

I ran some test traces and measurements with our PCIe 6323 card and with the fixes the traces and continuous sampling are working as intended. Let me know if there are any more changes needed before merging.