micro-manager / pymmcore

Python bindings for MMCore, Micro-Manager's device control layer
https://pypi.org/project/pymmcore/
GNU Lesser General Public License v2.1
33 stars 8 forks source link

Meson build, replacing setuptools #109

Open marktsuchida opened 8 months ago

marktsuchida commented 8 months ago

Limitation: The sdist (source distribution for PyPI) now contains the whole of mmCoreAndDevices and more (33 MiB). While technically functional, we should fix this before merging this change.

Update mmCoreAndDevices to latest (which has meson.build for MMCore and MMDevice).

Add Meson build file.

Use meson-python so that python -m build just works via pyproject.toml.

Move the single source of truth for the version number from _version.py (now generated) to meson.build.

The Meson build has several advantages:

The main disadvantage is that MANIFEST.in can no longer be used to control what gets included in the sdist (meson-python uses meson dist to produce the sdist, which includes all version-controlled files). However, once we are ready to use MMDevice and MMCore from independent repositories, this will no longer be an issue (and ends up being simpler than the error-prone MANIFEST.in).


marktsuchida commented 8 months ago

Rebased and squashed.

Regarding the remaining issue (cannot produce correct sdist that doesn't include the massive mmCoreAndDevices), there are 3 possible solutions I can think of:

Given that this Meson-based build does not add any user-facing benefits, I'm inclined to take the first approach and keep this draft PR open and maintained until we're ready. It has already served to iron out at least some of the issues we'll likely encounter when moving MMCoreJ to Meson.