search

micro-manager / pymmcore

Python bindings for MMCore, Micro-Manager's device control layer
https://pypi.org/project/pymmcore/
GNU Lesser General Public License v2.1
33 stars 8 forks source link

Fix macOS CI #117

Closed marktsuchida closed 4 months ago

marktsuchida commented 4 months ago

~Work in progress -- as I haven't managed to reproduce the issue locally.~

Upgrade to macos-12 for wheel building.

tlambert03 commented 4 months ago

that seems to have done it :joy:
we might also consider adding -v to swig_opts in setup.py?

tlambert03 commented 4 months ago

that seems to have done it 😂

oh never mind... we'll need to temporarily let the Build & deploy / Build wheels on ${{ matrix.os }} ${{ matrix.macos_arch }} (pull_reques job run on pull requests... and just make sure it's not pushing to pypi

marktsuchida commented 4 months ago

Presumably the cause was that the SWIG binary we're using crashes on macOS 11 (but not 12). I suspected that it was built for 12+ but

$ otool -l venv/lib/python3.11/site-packages/swig/data/bin/swig  |grep minos
    minos 11.0

(PyPI swig 4.2.1 on arm64) so maybe it crashes at run time even though not rejected by the OS.

(Or maybe it was some other weird transient issue, but I'm happy it's fixed!)

marktsuchida commented 4 months ago

(Force-pushed to re-disable wheels for PRs.)