search

micro-manager / pymmcore

Python bindings for MMCore, Micro-Manager's device control layer
https://pypi.org/project/pymmcore/
GNU Lesser General Public License v2.1
33 stars 8 forks source link

Enable SWIG Python threading support #50

Closed ianhi closed 3 years ago

ianhi commented 3 years ago

Maybe fixes #49 Opening a PR to have github actions action build the wheel so I can try it out.

marktsuchida commented 3 years ago

Mind if I change this to use %module("threads"=1) inside the .i file instead of relying on command line args? Mostly because I think it's an inherent requirement for the wrapper rather than a build configuration.

ianhi commented 3 years ago

Mind if I change this to use %module("threads"=1) inside the .i file instead of relying on command line args? Mostly because I think it's an inherent requirement for the wrapper rather than a build configuration.

Please go for whatever you think is best! I'm happy to close this if you open a different PR

marktsuchida commented 3 years ago

@ianhi Great, I just pushed to your branch (sorry for the CI noise it may have created on your fork). I think this should be merged whether or not it fully fixes #49, but I'll wait for you to give it a try, just in case there are any surprises.

ianhi commented 3 years ago

@marktsuchida 🎉 🎉 🎉 it does indeed fix #49 🎉 🎉 🎉

(and thus far no surprises - though may not be able to check too much as it's unclear if my microfluidic skills were up to snuff today :( )

tlambert03 commented 3 years ago

amazing!! great job!