search

micro-manager / pymmcore

Python bindings for MMCore, Micro-Manager's device control layer
https://pypi.org/project/pymmcore/
GNU Lesser General Public License v2.1
32 stars 8 forks source link

fix: update dockerfile #77

Closed ianhi closed 1 year ago

ianhi commented 1 year ago

The dockerfile was failing for two reasons:

  1. Wasn't properly downloading the mmCoreAndDevices submodule
  2. seems libboost is still needed

@marktsuchida is there any clever way we could change this to only include the democamera rather than every device adapter?

marktsuchida commented 1 year ago

is there any clever way we could change this to only include the democamera rather than every device adapter?

Unfortunately, no. Probably the easiest is to avoid make install and copy just the DemoCamera adapter (if the wasted build time is acceptable).

Or we could add an option (in mmCoreAndDevices/DeviceAdapters/configure.ac) to build DemoCamera (and possibly Utilities) only, although that would mean more Autoconf code to maintain.

Boost is still needed for device adapters.

Thanks for the fixes!