micro-nova / AmpliPi

Whole House Audio System 🔊
https://amplipi.com
GNU General Public License v3.0
287 stars 23 forks source link

Show firmware version in web UI #350

Closed Lohrer closed 5 months ago

Lohrer commented 2 years ago

Currently the AmpliPi software version is shown at the bottom of the web UI, we should add the firmware version as well and report it in our logs to give full visibility to the fw version.

Our API currently reports the version in the info field.

The Info model can be found in amplipi/models.py

Here's what it looks like on a main unit without an expander:

{
  "version": "0.3.5+b09fc53-update-spotifyd",
  "config_file": "house.json",
  "mock_ctrl": false,
  "mock_streams": false,
  "is_streamer": false,
  "online": true,
  "latest_release": "0.3.5",
  "access_key": "",
  "lms_mode": false,
  "fw": [
    {
      "version": "1.8",
      "git_hash": "1743bfb",
      "git_dirty": false
    }
  ],
  "stream_types_available": [
    "rca",
    "airplay",
    "spotify",
    "internetradio",
    "dlna",
    "pandora",
    "plexamp",
    "aux",
    "fileplayer",
    "lms"
  ]

Here's what it looks like on an expander:

{
  "version": "0.3.1",
  "config_file": "house.json",
  "mock_ctrl": false,
  "mock_streams": false,
  "is_streamer": true,
  "online": true,
  "latest_release": "0.3.5",
  "access_key": "",
  "lms_mode": false,
  "fw": []
}

Also for browsing the API I suggest using either insomnia or our hosted interactive api docs. They can be found at settings->about->Browsable API

Lohrer commented 2 years ago

@linknum23, should we consider showing up to 6 expansion unit firmware versions?

linknum23 commented 2 years ago

Definitely!

On Fri, Aug 19, 2022 at 5:42 PM Michael Lohrer @.***> wrote:

@linknum23 https://github.com/linknum23, should we consider showing up to 6 expansion unit firmware versions?

— Reply to this email directly, view it on GitHub https://github.com/micro-nova/AmpliPi/issues/350#issuecomment-1221112869, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEZPO34USTT53PMZ73CFWTVZ75TTANCNFSM53HWK3EQ . You are receiving this because you were mentioned.Message ID: @.***>

linknum23 commented 2 years ago

The backend support for this is being added in #356

Lohrer commented 5 months ago

Another important add here is we should be reporting the firmware version in the logs so that support can see it.

linknum23 commented 5 months ago

@npunniyamoorthy I updated the description to give you more of a guide on this. I hope it helps!

linknum23 commented 5 months ago

Oops we should have linked this to #714 so it was automatically closed. Closing it now.