micro-nova / AmpliPi

Whole House Audio System 🔊
https://amplipi.com
GNU General Public License v3.0
284 stars 23 forks source link

No confirmation dialog for options on config page #580

Closed gorski123 closed 2 months ago

gorski123 commented 8 months ago

When uploading a new config, resetting the box back to factory config, performing a HW reset, etc, It would probably be a good idea to first show a pop-up dialog confirming the choice. Then there should be some type of spinner while the action is performed, followed by some type of confirmation that the selected action has been completed.

SteveMicroNova commented 8 months ago

This should be fairly easy to achieve, we already use the React library that contains a loading spinner

I'm not able to spend time to this rn but there's the solution for whenever someone takes on this issue, just put that spinner in the right place and make sure it's only visible while the config is loading

rtertiaer commented 4 months ago

probably deserve to do the same with LMS mode, particularly beause it downloads some config