micro-nova / AmpliPi

Whole House Audio System 🔊
https://amplipi.com
GNU General Public License v3.0
285 stars 23 forks source link

Frontend looks silly on some tablets #945

Open SteveMicroNova opened 1 day ago

SteveMicroNova commented 1 day ago

image See image, in my test of what the frontend would look like on a Surface Pro 7 the main ui only took up the upper half of the screen in portrait mode

It may be worth having further dynamic css to make the StreamCards dynamically taller when the screen has a certain width:height ratio

SteveMicroNova commented 1 day ago

This could probably also be done without checking viewport size by setting their height to like 20vh but their minHeight to whatever height is set to now, that way it'll fill the screen but it won't harm the experience of shorter screens

SteveMicroNova commented 1 day ago

Note that regardless of implementation, you'll need to contend with how the ui within the cards displays That might be a minor headache that would be best achieved with a 2d MUI Grid imo

I did something similar in #703, the solution to the dynamic ui scaling might lie there