Closed kobergj closed 9 months ago
While I like the base32 encoding here for simplicity, I believe this should be optional. Yeah, can be by default on.
Why:
So what do you think?
Yes. Good point. :+1: I introduced EncodeKeys
option. Default is false
because this is what I would expect.
@jochumdev since this a new store and not just some fix or enhancement, I would very much appreciate your approve before I merge it
Adds a store
nats-js-kv
based on nats-js KeyValue interface. Instead of using streams to store the data (like thenats-js
store does) it will store the data in jetstreams key value stores.Some implementation details:
base32
encoded to work around limited characters usable as keys for the storeList
calls can take quite long when there are many keys in a bucket. Might need a follow-up to fixnats-js
package to have the same test coverage. We should think about running the same testsuite against all stores.I also needed to edit the
.golangci.yml
to make it possible getting green pipelines:depguard
linter had a wrong format