search

micro / services

Real World Micro Services
Apache License 2.0
1.26k stars 138 forks source link

clean up password reset code #375

Closed domwong closed 2 years ago

domwong commented 2 years ago

Addressing issues brought up in https://github.com/micro/services/issues/373

lambdaR commented 2 years ago

I tested it and it seems flawless, better than the otp approach. One thing I have learned today is that you can set an expiry to record that's neat. Regarding the email service, is there a way to speed up the delivery just for critical services like this one? statistically speaking, these types of emails are less frequent than the other ones.

domwong commented 2 years ago

@lambdaR I think the only thing we could probably do to help email deliverability is to use a different IP address for sending. What email provider are you seeing slow deliveries to? It seems pretty quick (< 1 min) for gmail.com

lambdaR commented 2 years ago

@domwong basically mail.ru ... Knowing that from gmail.com - > mail.ru and vice versa is almost instant