[REGRESSION] zip-install.sh fails (version v1.2.0-beta)

[ildar]

Used to work on version https://github.com/micro5k/microg-unofficial-installer/actions/runs/3663872008 Tried both on r/o and r/w / Also debug log is not created.

console

```sh :/mnt/tmp/1 # DEBUG_LOG=1 INSTALL_NEWPIPE=0 sh ./zip-install.sh /sdcard/Download/microg-unofficial-installer-v1.2.0-beta-by-ale5000-OSS-signed.zip PRELOADER 1 PRELOADER 2 Extracting 64-bit ARM BusyBox... Extracting scripts... Starting installation script... --------------------------------------------------- INFO: Select the VOLUME + key to enable live setup. Waiting input for 2 seconds... WARNING: Key detection failed WARNING: The '/system' partition is read-only, it will be remounted mount: can't find /system in /proc/mounts mount: mounting /system on /system failed: Invalid argument ERROR: Remounting of '/system' failed ERROR 91: Remounting of '/system' failed ERROR: Installation script failed with error 91 ERROR 91: Installation script failed with error 91 ERROR: ZIP installation failed 91|:/mnt/tmp/1 # mount -o rw,remount / :/mnt/tmp/1 # DEBUG_LOG=1 INSTALL_NEWPIPE=0 sh ./zip-install.sh /sdcard/Download/microg-unofficial-installer-v1.2.0-beta-by-ale5000-OSS-signed.zip PRELOADER 1 PRELOADER 2 Extracting 64-bit ARM BusyBox... Extracting scripts... Starting installation script... --------------------------------------------------- INFO: Select the VOLUME + key to enable live setup. Waiting input for 2 seconds... WARNING: Key detection failed WARNING: The '/system' partition is read-only, it will be remounted mount: can't find /system in /proc/mounts mount: mounting /system on /system failed: Invalid argument ERROR: Remounting of '/system' failed ERROR 91: Remounting of '/system' failed ERROR: Installation script failed with error 91 ERROR 91: Installation script failed with error 91 ERROR: ZIP installation failed ```

[ale5000-git]

I have never tried but the variables are set from settings.conf and from live setup, so the ones provided directly will likely be overriden.

I think the remounting problem should already be fixed, have you tried the zip from the latest commit?

[ildar]

On Tue, Jan 24, 2023 at 10:25 AM ale5000 wrote:

I have never tried but the variables are set from settings.conf and from live setup, so the ones provided directly will likely be overriden.

then at least it's a good idea writing a log by defaut IMHO

I think the remounting problem should already be fixed, have you tried the zip from the latest commit?

I'll try a bit later. Thanks.

[ale5000-git]

Now it use DEBUG_LOG from the environment but I don't want to do it for every settings since it will overcomplicate things.

[ildar]

The CI build worked, thanks.

[ale5000-git]

I have also fixed the live setup, it will be in the new version once released.