microadam / drone-config-changeset-conditional

The Unlicense
65 stars 17 forks source link

support 1.0 yaml syntax #1

Closed bradrydzewski closed 5 years ago

bradrydzewski commented 5 years ago

awesome work! would this also support the 1.0 yaml syntax? I only ask because the example in the readme is using the 0.8 yaml syntax.

kind: pipeline
name: default

steps:
- name: frontend
   image: node
   commands:
     - cd app
     - npm run test
   when:
      changeset:
        includes: [ **/**.js, **/**.css, **/**.html ]

trigger:
  changeset:
    includes: [ **/**.go ]
Pajk commented 5 years ago

I just tested it with 1.0 and after fixing one bug (#2) it works well.

microadam commented 5 years ago

Apologies @bradrydzewski! I have only just seen this. Yes, this works with 1.0 already using triggers, I lazily copied the example from the original proposal PR. Will update the README with the 1.0 syntax (as I have only ever used this on 1.0). Thanks for spotting!