search

microadam / drone-config-changeset-conditional

The Unlicense
65 stars 17 forks source link

include vs includes? #18

Open jimsheldon opened 5 years ago

jimsheldon commented 5 years ago

Hello!

We are very interested in using this plugin, but we are hoping to "future proof" it as much as possible.

Currently the required syntax is:

   when:
      changeset:
        includes: [ **/**.js, **/**.css, **/**.html ]

and

trigger:
  changeset:
    includes: [ **/**.go ]

All other drone syntax seems to use include rather than includes. Would you consider a new version of this plugin with a breaking change that switches to include to match drone's official syntax? Or maybe there is a way this plugin could support both include and includes?

microadam commented 5 years ago

Hi @jimsheldon more than happy for it to support both :)