search

microadam / drone-config-changeset-conditional

The Unlicense
65 stars 17 forks source link

fix(#31): preserve skipped steps to avoid Drone DAG reference errors #32

Closed kdnutrien closed 3 years ago

kdnutrien commented 3 years ago

This PR preserves skipped steps and instead adds an impossible condition to them prior to output: when: { event: { excludes: ['*'] } }

This way, Drone will know about all steps and can construct the complete DAG when using depends_on without throwing reference errors.

kdnutrien commented 3 years ago

Closes #31

microadam commented 3 years ago

like it! Thank you very much :)

kdnutrien commented 3 years ago

Thanks! Would you mind pushing it up to Dockerhub as well? Could maybe tag it as 2.0.0 We've got an internal ECR repo, but using dockerhub is slightly easier.

microadam commented 3 years ago

hi @kdnutrien I pushed it to the latest tag yesterday after I merged. I thought about versioning, but as its backwards compatible, I didn't use a specific tag. Shout if you have issues