search

microadam / drone-config-changeset-conditional

The Unlicense
65 stars 17 forks source link

Include all file changes for branches/PRs #9

Closed calmyournerves closed 5 years ago

calmyournerves commented 5 years ago

Hey there 👋

Thanks for this awesome plugin! We're using it to run different pipelines depending on the files changed. So when something in a shared library changes, we would trigger all repos that use this library.

What we noticed though, is that when working on a feature branch, it would always only include the file changes from the last commit. We kind of expected it to include all changes to the current branch or PR, ensuring that everything that depends e.g. on a shared library is always triggered.

This PR adds that. So when a commit comes from the non-default branch, it will diff the current commit against the default branch and include all file changes.

I'm not sure this is something you want to include in this plugin or if it is feasible for you at all. Maybe it should go behind a setting? Let me know!

microadam commented 5 years ago

Hi @calmyournerves I think this is far to specific a use case for this plugin to handle. I would have thought you would want it to compare the commit against the branch the current branch was based off of, not just the "default" branch, as it might not have been based off of that one

calmyournerves commented 5 years ago

Hey @microadam! Thanks for the response. You're right, comparing it against the base branch would be even better (not sure if GitHub sends this info as payload though). Comparing it against the default branch works well enough for us at the moment.

I'll go ahead and close this for now, we'll keep running our instance off our fork. If others have the same issue and/or this becomes a use case you want to handle in the future we can have a look again.