search

microapps / gatsby-plugin-react-i18next

Easily translate your Gatsby website into multiple languages
MIT License
121 stars 72 forks source link

Fix gatsby-plugin-sitemap example #112

Closed xmflsct closed 2 years ago

xmflsct commented 2 years ago

As of v4 the 'exclude' option was renamed to 'excludes', see https://www.gatsbyjs.com/plugins/gatsby-plugin-sitemap/?=sitemap#options

stevensacks commented 2 years ago

This would break for anyone still using Gatsby 2 or 3, correct? So this merge would need to be a major version update to this plugin, I think.

@jimmyn What do you think?

psykzz commented 2 years ago

This wouldn't break anything since its documentation, personally i think its correct to always have the most up to date documentation, and if you really wanted, to call out that this is different from version 2/3 and that they should pay attention if thats the version they are using.