Changing messages comments/descriptions affects protocol version

microavia / messgen

MIT License

9 stars 11 forks source link

Open Roman- opened 1 year ago

Roman- commented 1 year ago

Here is what protocol version calculator should take into account:

Msgs IDs and names
Order of msgs fields and their types
Fields names (e.g. changing single field name from "uint32 capacity_liters" to "uint32 capacity_ml" must change the hash)

Fields comments and message descriptions must not affect protocol version

Roman- commented 10 months ago

Reverted pull request as it did not consider swapping two consecutive data with same size