search

microbean / microbean-service-broker-jaxrs

A JAX-RS implementation of the Open Service Broker specification.
https://microbean.github.io/microbean-service-broker-jaxrs/
Apache License 2.0
1 stars 0 forks source link

NullPointerException when invoked by service-catalog 0.0.1 #1

Open ljnelson opened 6 years ago

ljnelson commented 6 years ago

When the Kubernetes service catalog, ancient and unsupported version 0.0.1, hits the ServiceInstancesResource#deleteServiceInstance() method, a NullPointerException results:

SEVERE: java.lang.NullPointerException
java.lang.NullPointerException
at java.util.Objects.requireNonNull(Objects.java:203)
at org.microbean.servicebroker.jaxrs.ServiceInstancesResource.deleteServiceInstance(ServiceInstancesResource.java:245)

This is probably valid in the sense that whatever is being asserted probably should NOT be null, but we need to make sure.

ljnelson commented 6 years ago

The line in question, 245, is this:

Objects.requireNonNull(serviceId);

...where serviceId is a @QueryParam-annotated parameter. So the ancient and unsupported version 0.0.1 of the Kubernetes service catalog is not passing the (required) serviceId parameter.