Open jkc9886 opened 3 months ago
Thanks!
Regression is indeed a common statistical technique.
The primary focus of OMA is to teach Bioconductor methods that support the modern multi-assay data containers, in particular the (Tree)SummarizedExperiment and MultiAssayExperiment but possibly others. OMA is not a book about general statistics (a topic which has more comprehensive treatments elsewhere). A key shortcoming in this example is that it does not show how to do regression on such data objects.
Another gap is in the statistical assumptions; read counts or relative abundances in microbiome context usually violate assumptions of standard linear regresssion in multiple ways and that is pedagogically not ideal. Examples on GLMs would be better justified but for those we do have DA tests already available for individual taxa.
If we keep linear regression example then I would implement following changes:
I am working on your suggested changes but I see the PR has been approved to merge, is it a technical error or should I continue with adding the changes?
This PR has not been merged.
If you check those "merge" announcements above you can see that they are instead synchronizing this PR with the other PRs that have been approved meanwhile. So the changes from other PRs in the devel branch are merged into your branch to keep it up-to-date, but your branch has not been merged yet to devel branch..
Oh I see, i get it now, thank you Professor!
There is one major comment related to the use of lm:
1) Your current use case with discrete x, continuous y can be done but is possibly a bit less standard than simple x,y scatterplot with continuous x. For this, scatterplot and geom_smooth are not recommended visualizations as they are designed for continouous x. Use instead boxplots or violin plots to visualize this kind of data (with discrete x).
2) Use with continuous variables (both x, y) is common use case and can be visualized with scatterplots & geom_smooth; this is a common use case and for clarity it would be good to also include example on this. Then the coefficients have different interpretation.
@jkc9886 is this ready from your side?
Yes Professor.
Hi @jkc9886 - this PR is still unmerged. Would you help us to finalize this task you initiated?
Yes, sure Professor. I shall work on the comments suggested by Tuomas and send the edits.
On Sun, Nov 10, 2024 at 11:26 PM Leo Lahti @.***> wrote:
- this PR is still unmerged. Would you help us to finalize this task you initiated?
— Reply to this email directly, view it on GitHub https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_microbiome_OMA_pull_591-23issuecomment-2D2466855485&d=DwMCaQ&c=slrrB7dE8n7gBJbeO0g-IQ&r=fvCQdMIyOhlZ3JXGliOTRQ&m=YC1zQpLhXKKo-ffDr1EJrYp_-1btb5wJ814atDwHJgRy3z3rOQePW2ia38hFsbw6&s=JyttnDscqTcAS9V2dC37-_WgD5H3-YDn8NoNFFI1h28&e=, or unsubscribe https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_A7UNPARCAPNGFXFRFAQ4UULZ76XP5AVCNFSM6AAAAABL4PZEIGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINRWHA2TKNBYGU&d=DwMCaQ&c=slrrB7dE8n7gBJbeO0g-IQ&r=fvCQdMIyOhlZ3JXGliOTRQ&m=YC1zQpLhXKKo-ffDr1EJrYp_-1btb5wJ814atDwHJgRy3z3rOQePW2ia38hFsbw6&s=zepbJDfwNBVtFhQA2mvomL0fD8taML2_WHUV31SFDcc&e= . You are receiving this because you were mentioned.Message ID: @.***>
One of the methods to visualize microbiome data in the OMA book chapters is regression charts, however there was no example or mention about it in the exercises chapter.
I have added:
Please suggest if this could be added and if yes, what better could be done?