search

microbiome / bluster

Clone of the Bioconductor repository for the bluster package.
https://bioconductor.org/packages/devel/bioc/html/bluster.html
0 stars 0 forks source link

Addition of the contributors to the DESCRIPTION file #4

Closed BananaCancer closed 1 year ago

BananaCancer commented 1 year ago

Added Leo, Tuomas and myself as contributors.

TuomasBorman commented 1 year ago

I think you could still add to dist.fun the function requirement. Must have method parameter for specifying dissimilarity measure. And its output must be dissimilarity matrix. --> if those requirements are not fulfilled it leads to an error (it could be good to notify user.)

BananaCancer commented 1 year ago

How is that @TuomasBorman ?

TuomasBorman commented 1 year ago

Hmmm, how about

@param dist.fun Function specifying the function to use to compute the distance matrix. Must be stats::dist-like function.

Is that clear? What you think?

BananaCancer commented 1 year ago

It's clear if people reading know what you mean. I can do a mix of the two @param dist.fun Function specifying the function to use to compute the distance matrix. Must be stats::dist-like function. i.e. takes a method as a parameter and returns a dissimilarity matrix Is that ok?

TuomasBorman commented 1 year ago

Yes, sounds feasible

BananaCancer commented 1 year ago

Is this version ok to merge @TuomasBorman ?