microbiome / iSEEtree

extension of iSEE for TreeSE
https://microbiome.github.io/iSEEtree/
3 stars 2 forks source link

Add parameters to data boxes of current panels #25

Closed RiboRings closed 4 months ago

RiboRings commented 5 months ago

Most of the data boxes of the current panels are still empty. Meaningful data parameters should be discussed and added.

The main difference between data box and visualisation box is that data boxes should contain parameters that significantly change the data in a plot (number of points, values of the axes, measured metric, transformations, etc.), whereas visualisation parameters just change aesthetics (shape by, colour by, etc.).

ElySeraidarian commented 4 months ago

Hey, I am currently trying to add some data parameters however I'm not sure which one could be added (and not considered a visual one) so here is a quick list I made.

AbundancePlot :

AbundanceDensityPlot :

RowTreePlot :

It feels like a lot could be also visual parameters so I want to be sure which to add

RiboRings commented 4 months ago

AbundancePlot:

AbundanceDensityPlot

RowTreePlot

RiboRings commented 4 months ago

Some other possible ideas for the RDAPlot:

antagomir commented 4 months ago

Would be good to coordinate with mia/miaVIz: if some of these options could/should be made available there, then just called here, that might be preferable?

ElySeraidarian commented 4 months ago

These are already existing parameters in miaViz functions, we are just creating ways to change these parameters in our visualization plot.

RiboRings commented 4 months ago

Completed with https://github.com/microbiome/iSEEtree/pull/28