microbiome / mia

Microbiome analysis
https://microbiome.github.io/mia/
Artistic License 2.0
50 stars 27 forks source link

loadFrom* documentation #332

Closed antagomir closed 4 months ago

antagomir commented 1 year ago

The function loadFromBiom has outdated example section:

Suggestion: fix this and check other functions for similar issue.

This is the problematic example:

   if(requireNamespace("biomformat")) {
       library(biomformat)
       # load from file
       rich_dense_file  = system.file("extdata", "rich_dense_otu_table.biom",
                                      package = "biomformat")
       se <- loadFromBiom(rich_dense_file, removeTaxaPrefixes = TRUE)

       # load from object
       x1 <- biomformat::read_biom(rich_dense_file)
       se <- makeTreeSEFromBiom(x1)
       # Convert SE to TreeSE
       tse <- as(se, "TreeSummarizedExperiment")
       tse
     }
kakonodia commented 1 year ago

Hello @antagomir i would like to work on this issue would you assign it to me ?

antagomir commented 1 year ago

Would be great if you can check the other functions / R files for the same issue on the same go!

TuomasBorman commented 1 year ago

This is already done @RiboRings ?

RiboRings commented 10 months ago

Hi! Yes, this is done.