search

microbiome / mia

Microbiome analysis
https://microbiome.github.io/mia/
Artistic License 2.0
46 stars 27 forks source link

Wrong deprecation message with mergeFeatures #416

Closed antagomir closed 10 months ago

antagomir commented 1 year ago

We get wrong warning:

library(mia)
data(GlobalPatterns, package="mia")
tse <- GlobalPatterns 
mergeFeatures(tse, f="Genus")

'mergeRows' is deprecated. Use 'mergeFeatures' instead.

-> We should get this deprecation message only when mergeRows is called, not when mergeFeatures is called.

-> To check also for other deprecated functions.

TuomasBorman commented 10 months ago

Is this done? @ake123

ake123 commented 10 months ago

it was done!

antagomir commented 10 months ago

Can you close issues that you have solved (like this one?).

ake123 commented 10 months ago

It looks like this fix is being reset for some reason so I need to fix it again

ake123 commented 10 months ago

Now it is fixed