search

microbiome / mia

Microbiome analysis
https://microbiome.github.io/mia/
Artistic License 2.0
46 stars 27 forks source link

loadFromBiom bugfix #431

Closed TuomasBorman closed 12 months ago

TuomasBorman commented 1 year ago

Hi,

I found a bug. Additionally, I polished the code little bit

ChouaibB commented 1 year ago

I need more coffee :/ , I just realized that you did the whole fixing and work, I first thought you requested me to do the changes. Thanks Tuomas all looks good for me.

TuomasBorman commented 1 year ago

I need more coffee :/ , I just realized that you did the whole fixing and work, I first thought you requested me to do the changes. Thanks Tuomas all looks good for me.

:D yes I was fast --> good, I will still check this through

ChouaibB commented 1 year ago

Thanks a lot :)

TuomasBorman commented 1 year ago

I simplified the code, check if it is still good.

I removed warnings since there are also no warnings when prefixes are removed. Or do you think they are necessary?

ChouaibB commented 12 months ago

Removing the warnings is ok I guess as long as all is parsed well. I think at the end of the day the user itself should do some double checks after building/importing the object. All good :) Thanks :)