search

microbiome / mia

Microbiome analysis
https://microbiome.github.io/mia/
Artistic License 2.0
46 stars 27 forks source link

subset functions and trees #443

Closed TuomasBorman closed 1 month ago

TuomasBorman commented 11 months ago

It seems that subset functions do not have parameter for updating the rowTree (mergeFeatureByRank has...). Moreover, agglomerateByPrevalence seems to drop rowTree completely

--> check

TuomasBorman commented 11 months ago

mergeFeatureByRank's agglomerateTree seems not to agglomerate the tree but rather create a new one from the agglomerated rowData

I think it should just drop those tips that are not present anymore

antagomir commented 1 month ago

@ake123 is this ready?

ake123 commented 1 month ago

yes it's ready

antagomir commented 1 month ago

Can you close all issues that are ready?