search

microbiome / mia

Microbiome analysis
https://microbiome.github.io/mia/
Artistic License 2.0
46 stars 27 forks source link

Update biom import examples #446

Closed RiboRings closed 11 months ago

RiboRings commented 11 months ago

Hi! I have updated the examples on biom import. Checking for related things to do.

TuomasBorman commented 11 months ago

Im wondering if this works also in system that does not have biomformat installed (especially if this works in Bioc system; sometimes they work in GHA but not in Bioc). biomformat is not dependency of mia, it is just dependency of loadFromBiom function

RiboRings commented 11 months ago

I see! Then should it work if I put this back?

#' if(requireNamespace("biomformat")) {
#'   library(biomformat)
TuomasBorman commented 11 months ago

I see! Then should it work if I put this back?

#' if(requireNamespace("biomformat")) {
#'   library(biomformat)

Well, in practice they could be removed, I think, if biomformat is listed in suggests https://pecanproject.github.io/pecan-documentation/master/declaring-dependencies-depends-suggests-imports.html