search

microbiome / mia

Microbiome analysis
https://microbiome.github.io/mia/
Artistic License 2.0
46 stars 25 forks source link

consider removing set.seed() inside the functions #468

Closed erawijantari closed 7 months ago

erawijantari commented 9 months ago

When I run BiocCheck::BiocCheck(), it was suggested to remove set.seed inside the functions, subsampleCounts.R has 1 line that set seed inside the functions (line 133)

antagomir commented 9 months ago

PR welcome.

erawijantari commented 7 months ago

Based on the suggestions here: https://support.bioconductor.org/p/110439/, I removed the set.seed() inside the function and specify that user can define seeds before applying subsampleCounts().