search

microbiome / mia

Microbiome analysis
https://microbiome.github.io/mia/
Artistic License 2.0
45 stars 25 forks source link

taxonomyranks #501

Closed ake123 closed 3 months ago

ake123 commented 4 months ago

Addition of setTaxonomyRanks and getTaxonomyRanks functions Addition of a new internal function .set_taxonomy_ranks

TuomasBorman commented 4 months ago

Some discussion in earlier PR https://github.com/microbiome/mia/pull/476

antagomir commented 3 months ago

up

antagomir commented 3 months ago

Is this ready?

ake123 commented 3 months ago

Yes it's ready

antagomir commented 3 months ago

It seems that @TuomasBorman must also approve this also before we can merge.

Can we reduce the number of reduced approvals to "1" per PR somehow btw?

TuomasBorman commented 3 months ago

The code is good, although tests are missing.

TuomasBorman commented 3 months ago

The merging is blocked if changes are requested (I believe there is no way to go around this rule.) There is no minimum amount of approvals in our rules

antagomir commented 3 months ago

@ake123 could you add some unit tests in a separate PR?

ake123 commented 3 months ago

Yes Sure!