search

microbiome / mia

Microbiome analysis
https://microbiome.github.io/mia/
Artistic License 2.0
45 stars 25 forks source link

new generic function agglomerateByVariable #507

Closed thpralas closed 2 months ago

thpralas commented 3 months ago

Create a new generic function agglomerateByVariable to replace the methods mergeCols and mergeRows. agglomerateByVariable takes parameter MARGIN to specify wether to run mergeCols or mergeRows

TuomasBorman commented 2 months ago

Check those comments. I think this looks good

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 42.06349% with 73 lines in your changes are missing coverage. Please review.

:exclamation: No coverage uploaded for pull request base (devel@989206b). Click here to learn what that means.

:exclamation: Current head 35f6660 differs from pull request most recent head 60a79d8. Consider uploading reports for the commit 60a79d8 to get more accurate results

Files Patch % Lines
R/deprecate.R 11.11% 48 Missing :warning:
R/merge.R 52.38% 20 Missing :warning:
R/agglomerate.R 80.76% 5 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## devel #507 +/- ## ======================================== Coverage ? 72.40% ======================================== Files ? 40 Lines ? 4678 Branches ? 0 ======================================== Hits ? 3387 Misses ? 1291 Partials ? 0 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

antagomir commented 2 months ago

Seems good! Conflicts to be resolved